Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle auto height in card resize editor #21260

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jul 3, 2024

Proposed change

Some cards don't have default sizes on the grid (entities card, glance card), This PR set the slider to the min value when the card have no rows defined.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Summary by CodeRabbit

  • New Features

    • Grid layout now supports "auto" value for rows, enhancing flexibility in grid size configuration.
    • Introduced styling adjustments for grid layout components when disabled.
  • Enhancements

    • Updated grid size editor and layout slider to handle new "auto" row values.
    • Imported new components (ha-settings-row, ha-switch) in the card layout editor for enhanced functionality.

@piitaya piitaya force-pushed the auto-height-card-resize-editor branch from 750e16d to 1ee3916 Compare July 3, 2024 12:32
@piitaya piitaya added this to the 2024.7 milestone Jul 3, 2024
@piitaya piitaya changed the title Add auto-height option to resize editor Better handle auto height in card resize editor Jul 3, 2024
@piitaya piitaya marked this pull request as ready for review July 3, 2024 13:22

This comment was marked as off-topic.

@piitaya

This comment was marked as off-topic.

@piitaya piitaya requested a review from bramkragten July 4, 2024 13:17
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 4, 2024
@piitaya piitaya merged commit 050bef0 into dev Jul 4, 2024
14 checks passed
@piitaya piitaya deleted the auto-height-card-resize-editor branch July 4, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants