Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to copy service response as json for templates #21226

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Button to copy service response as json for templates #21226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e12f16
Button to copy service response as json for templates
karwosts Jun 29, 2024
e46f7b2
Merge branch 'dev' of https://github.com/home-assistant/frontend into…
karwosts Jul 13, 2024
e059272
service -> action
karwosts Jul 13, 2024
b8096be
update
karwosts Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/components/ha-yaml-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ export class HaYamlEditor extends LitElement {

@property({ type: Boolean }) public copyClipboard = false;

@property({ type: Boolean }) public hasExtraActions = false;

@state() private _yaml = "";

public setValue(value): void {
Expand Down Expand Up @@ -100,13 +102,16 @@ export class HaYamlEditor extends LitElement {
@value-changed=${this._onChange}
dir="ltr"
></ha-code-editor>
${this.copyClipboard
${this.copyClipboard || this.hasExtraActions
? html`<div class="card-actions">
<mwc-button @click=${this._copyYaml}>
${this.hass.localize(
"ui.components.yaml-editor.copy_to_clipboard"
)}
</mwc-button>
${this.copyClipboard
? html` <mwc-button @click=${this._copyYaml}>
${this.hass.localize(
"ui.components.yaml-editor.copy_to_clipboard"
)}
</mwc-button>`
: nothing}
<slot name="extra-actions"></slot>
Copy link
Member

@bramkragten bramkragten Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be outside of the copyClipboard ternary, it is not possible to add extra actions now without adding the copy clipboard action.

Copy link
Contributor Author

@karwosts karwosts Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, is another property the best way to solve? I don't want to create the card-actions div if there aren't any actions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good! 👍

</div>`
: nothing}
`;
Expand Down
21 changes: 20 additions & 1 deletion src/panels/developer-tools/action/developer-tools-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@ import { hasTemplate } from "../../../common/string/has-template";
import { extractSearchParam } from "../../../common/url/search-params";
import { HaProgressButton } from "../../../components/buttons/ha-progress-button";
import { LocalizeFunc } from "../../../common/translations/localize";
import { showToast } from "../../../util/toast";
import { copyToClipboard } from "../../../common/util/copy-clipboard";

import "../../../components/entity/ha-entity-picker";
import "../../../components/ha-card";
import "../../../components/ha-alert";
import "../../../components/ha-button";
import "../../../components/ha-expansion-panel";
import "../../../components/ha-icon-button";
import "../../../components/ha-service-control";
Expand Down Expand Up @@ -189,8 +192,15 @@ class HaPanelDevAction extends LitElement {
copyClipboard
readOnly
autoUpdate
hasExtraActions
.value=${this._response}
></ha-yaml-editor>
>
<ha-button slot="extra-actions" @click=${this._copyTemplate}
>${this.hass.localize(
"ui.panel.developer-tools.tabs.actions.copy_clipboard_template"
)}</ha-button
>
</ha-yaml-editor>
</div>
</ha-card>
</div>`
Expand Down Expand Up @@ -292,6 +302,15 @@ class HaPanelDevAction extends LitElement {
`;
}

private async _copyTemplate(): Promise<void> {
await copyToClipboard(
`{% set action_response = ${JSON.stringify(this._response)} %}`
);
showToast(this, {
message: this.hass.localize("ui.common.copied_clipboard"),
});
}

private _filterSelectorFields = memoizeOne((fields) =>
fields.filter((field) => !field.selector)
);
Expand Down
1 change: 1 addition & 0 deletions src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6706,6 +6706,7 @@
"all_parameters": "All available parameters",
"accepts_target": "This action accepts a target, for example: `entity_id: light.bed_light`",
"no_template_ui_support": "The UI does not support templates, you can still use the YAML editor.",
"copy_clipboard_template": "Copy to clipboard (template)",
"errors": {
"ui": {
"no_service": "No action selected, please select an action",
Expand Down
Loading