Add storage variables for application credentials config table #21215
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range comments (1)
src/panels/config/application_credentials/ha-config-application-credentials.ts (1)
Line range hint
245-245: Specify a more precise type instead ofany.Using
anycan lead to potential bugs due to lack of type safety. Specify a more explicit type for the error in thecatchblock.- } catch (err: any) { + } catch (err: Error) {
| @@ -27,6 +28,7 @@ import type { HaTabsSubpageDataTable } from "../../../layouts/hass-tabs-subpage- | |||
| import { HomeAssistant, Route } from "../../../types"; | |||
| import { configSections } from "../ha-panel-config"; | |||
| import { showAddApplicationCredentialDialog } from "./show-dialog-add-application-credential"; | |||
| import { storage } from "../../../common/decorators/storage"; | |||
There was a problem hiding this comment.
Ensure consistent use of relative imports.
The import for storage uses a relative path that is quite deep. Consider using a more consistent or simplified path if possible, especially if there's a base path configuration that can be leveraged.
| private _handleSortingChanged(ev: CustomEvent) { | ||
| this._activeSorting = ev.detail; | ||
| } | ||
|
|
||
| private _handleColumnsChanged(ev: CustomEvent) { | ||
| this._activeColumnOrder = ev.detail.columnOrder; | ||
| this._activeHiddenColumns = ev.detail.hiddenColumns; | ||
| } |
There was a problem hiding this comment.
Refactor event handler methods for clarity and efficiency.
The methods _handleSortingChanged and _handleColumnsChanged directly mutate the state properties. Consider using a more declarative approach or ensuring that these mutations trigger the necessary updates in the UI.
- this._activeSorting = ev.detail;
+ this._setSorting(ev.detail);
- this._activeColumnOrder = ev.detail.columnOrder;
- this._activeHiddenColumns = ev.detail.hiddenColumns;
+ this._setColumnConfig(ev.detail.columnOrder, ev.detail.hiddenColumns);And implement the methods _setSorting and _setColumnConfig to handle the state updates more cleanly.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| private _handleSortingChanged(ev: CustomEvent) { | |
| this._activeSorting = ev.detail; | |
| } | |
| private _handleColumnsChanged(ev: CustomEvent) { | |
| this._activeColumnOrder = ev.detail.columnOrder; | |
| this._activeHiddenColumns = ev.detail.hiddenColumns; | |
| } | |
| private _handleSortingChanged(ev: CustomEvent) { | |
| this._setSorting(ev.detail); | |
| } | |
| private _handleColumnsChanged(ev: CustomEvent) { | |
| this._setColumnConfig(ev.detail.columnOrder, ev.detail.hiddenColumns); | |
| } |
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit