Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Move to view' operation #21142

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jun 23, 2024

Proposed change

When moving a card to a new dashboard, code was incorrectly taking the index of the view to move to, and incorrectly using this index to lookup a view in the dashboard being moved from, and getting an undefined view and throwing an exception.

This also means the move to section view check was not working correctly in this case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Summary by CodeRabbit

  • Bug Fixes
    • Updated internal reference to fix issues with card configuration in Lovelace dashboards.

Copy link
Contributor

coderabbitai bot commented Jun 23, 2024

Walkthrough

Walkthrough

The update in src/panels/lovelace/components/hui-card-options.ts addresses an issue with relocating cards between views on different dashboards. The change involves adjusting the code to fetch the view configuration from the selectedDashConfig rather than the lovelace.config, which ensures the "move to view" functionality works across dashboards.

Changes

File Path Change Summary
src/panels/lovelace/components/hui-card-options.ts Updated reference from this.lovelace!.config.views to selectedDashConfig.views for fetching views.

Assessment against linked issues

Objective Addressed Explanation
Allow moving cards to a view under a different dashboard (#20460)
Maintain functionality for moving cards within the same dashboard (#20460)
Ensure no new errors appear in the browser console related to this functionality (#20460)

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between cf1523e and 75730b4.

Files selected for processing (1)
  • src/panels/lovelace/components/hui-card-options.ts (1 hunks)
Additional context used
Biome
src/panels/lovelace/components/hui-card-options.ts

[error] 88-88: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 93-93: Forbidden non-null assertion. (lint/style/noNonNullAssertion)


[error] 94-94: Forbidden non-null assertion. (lint/style/noNonNullAssertion)


[error] 94-94: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 98-98: Forbidden non-null assertion. (lint/style/noNonNullAssertion)


[error] 105-105: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 114-114: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 124-124: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 131-131: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 137-137: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 144-144: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 154-154: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 163-163: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 172-172: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 181-181: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 190-190: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 283-283: Forbidden non-null assertion. (lint/style/noNonNullAssertion)


[error] 284-284: Forbidden non-null assertion. (lint/style/noNonNullAssertion)


[error] 285-285: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator


[error] 287-287: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator

Additional comments not posted (1)
src/panels/lovelace/components/hui-card-options.ts (1)

356-356: Correct usage of the selectedDashConfig object.

The change from using this.lovelace!.config.views[viewIndex] to selectedDashConfig.views[viewIndex] correctly targets the intended dashboard's configuration. This is crucial for the bugfix described in the PR.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range comments (1)
src/panels/lovelace/components/hui-card-options.ts (1)

Line range hint 88-88: Replace non-null assertions with optional chaining.

Multiple lines in the file use the TypeScript non-null assertion operator (!). This operator can lead to runtime errors if the object is null or undefined. It's safer to replace these with the optional chaining operator (?.), which includes runtime checks.

- this.lovelace!.config
+ this.lovelace?.config

- this.hass!.localize
+ this.hass?.localize

- this._cards!.length
+ this._cards?.length

Also applies to: 93-93, 94-94, 98-98, 105-105, 114-114, 124-124, 131-131, 137-137, 144-144, 154-154, 163-163, 172-172, 181-181, 190-190, 283-283, 284-284, 285-285, 287-287

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @karwosts!

@piitaya piitaya merged commit 4cc9e74 into home-assistant:dev Jun 24, 2024
14 checks passed
@karwosts karwosts deleted the fix-move-to-view branch June 24, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Move to view" no longer working when moving to another dashboard after updating to 2024.3
2 participants