-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add menu with remove option to application credentials #21139
Conversation
Warning Rate limit exceeded@bramkragten has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 41 minutes and 24 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes introduce an overflow menu for managing application credentials within the configuration panel. This menu includes a feature to remove credentials, which is accompanied by a dialog box for user confirmation before deletion. Additionally, translations for the confirmation dialog and the "Remove" button have been added to the English localization file. Changes
Sequence DiagramssequenceDiagram
participant User
participant UI as User Interface
participant HaConfig as HaConfigApplicationCredentials
participant Confirm as Confirmation Dialog
User ->> UI: Clicks on overflow menu
UI ->> HaConfig: Show overflow menu options
User ->> UI: Select "Remove credential"
UI ->> Confirm: Show confirmation dialog
User ->> Confirm: Confirms removal
Confirm ->> HaConfig: Trigger _removeCredential
HaConfig ->> UI: Remove credential and update UI
This sequence diagram illustrates the interactions when a user attempts to remove an application credential via the newly introduced overflow menu. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
src/panels/config/application_credentials/ha-config-application-credentials.ts
Show resolved
Hide resolved
src/panels/config/application_credentials/ha-config-application-credentials.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "delete", right?
https://design.home-assistant.io/#Text/remove-delete-add-create
Proposed change
It was only possible to delete by multiselect
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit