-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter name in zwave_js WS API #20981
Conversation
WalkthroughWalkthroughThe primary change involves renaming parameters in the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant HomeAssistant
participant ZWaveJSIntegration
User->>HomeAssistant: Request to grant security classes
HomeAssistant->>ZWaveJSIntegration: Call zwaveGrantSecurityClasses(entry_id, securityClasses, clientSideAuth)
ZWaveJSIntegration-->>HomeAssistant: Security classes granted
HomeAssistant-->>User: Confirmation of granted security classes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional context usedBiome
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range comments (3)
src/data/zwave_js.ts (3)
Line range hint
4-4
: Initialize all enum members explicitly to prevent potential bugs.- export enum InclusionState { + export enum InclusionState { + Idle = 0, + Including = 1, + Excluding = 2, + Busy = 3, + SmartStart = 4, + }Also applies to: 17-17, 73-73, 88-88, 127-127, 380-380
Line range hint
17-54
: Convertconst
enums to regular enums to ensure compatibility with bundlers and 'isolatedModules'.- export const enum InclusionStrategy { + export enum InclusionStrategy {Also applies to: 380-386
Line range hint
240-240
: Replaceany
with specific types to enhance type safety.- value: any; + value: number | string; // Adjust as per actual expected typesAlso applies to: 393-393, 439-439
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @raman325! Should we include this for 2024.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this works. We should include it, otherwise Z-Wave JS is broken.
Proposed change
Missed some changes in #20793
Addresses issue reported by @AlCalzone : https://discord.com/channels/330944238910963714/800356888827002880/1247090606233358427
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit