Replace ha-clickable-list-item with native material 3 components

[silamon]

Proposed change

Replace ha-clickable-list-item, either with a ha-list-item-new if embedded within a list or a ha-menu-item if embedded within a menu. I decided to remove the component since it's a normal thing in the new material components. It's a drop in replacement although the link will no longer trigger if you activate with a spacebar.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Integration startup time dialog still uses rounded icons (unlike elsewhere) #20865
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• Refactor
  • Updated various configuration panels to use new list and menu components for improved consistency and maintainability.
  • Replaced mwc-list and mwc-list-item with ha-list-new and ha-list-item-new.
  • Swapped ha-clickable-list-item with ha-menu-item and ha-button-menu with ha-button-menu-new.

These changes enhance the user interface by standardizing components across different configuration panels.

[coderabbitai]

Note

Reviews paused

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Walkthrough

Walkthrough

The recent changes focus on updating various components within the Home Assistant frontend to use new list and menu components. Specifically, mwc-list, mwc-list-item, ha-clickable-list-item, and ha-button-menu have been replaced with ha-list-new, ha-list-item-new, ha-menu-item, and ha-button-menu-new. These updates standardize the design and functionality across different configuration panels and dialogs, ensuring a consistent user interface and addressing issues such as mismatched icon styles.

Changes

Files	Changes Summary
src/panels/config/hardware/ha-config-hardware.ts	Replaced mwc-list and mwc-list-item with ha-list-new and ha-list-item-new.
src/panels/config/info/ha-config-info.ts	Replaced mwc-list and ha-clickable-list-item with ha-list-new and ha-list-item-new.
src/panels/config/integrations/ha-integration-overflow-menu.ts	Replaced ha-button-menu and ha-clickable-list-item with ha-button-menu-new and ha-menu-item.
src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts	Replaced ha-clickable-list-item with ha-button-menu-new and ha-menu-item.
src/panels/config/repairs/integrations-startup-time.ts	Replaced ha-clickable-list-item and mwc-list with ha-list-new and ha-list-item-new.

Assessment against linked issues

Objective	Addressed	Explanation
Integration startup time dialog should not use rounded icons (#20865)	✅

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 4f975d9 and b116862.

Files selected for processing (1)

• src/panels/config/repairs/integrations-startup-time.ts (7 hunks)

Additional context used

Biome

src/panels/config/repairs/integrations-startup-time.ts

[error] 50-50: Change to an optional chain.

---

[error] 1-8: Some named imports are only used as types.

---

[error] 10-17: Some named imports are only used as types.

Additional comments not posted (2)

src/panels/config/repairs/integrations-startup-time.ts (2)

21-22: Imports updated to use new components.

---

Line range hint 21-83: The changes are consistent with the PR objectives and address the linked issues effectively.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Quentame]

Seems nice 👍

[steverep]

Made a small import correction, but still reviewing for a11y. This is my first detailed look at the M3 lists and it seems they've solved some a11y issues but introduced others. 😞

[silamon]

Could you clarify what changes you noticed? This PR isn't really focused on accessibility, but if makes things worse, I'm not really going forward with it.

[steverep]

Could you clarify what changes you noticed?

Menu items no longer activating on space key is a significant regression, especially since it sort of appears to activate by closing the menu. I don't know how they could miss such basic a11y there.

The static lists have ARIA that is just plain wrong (native anchors with a non-interactive role="listitem" and no container list role). The regression on those is the fact that the link role is no longer exposed to assistive technology.

I've briefly tried messing with the attributes to fix but not having success. I need to look at their code and probably file some issues if they don't exist already.

[silamon]

The spacebar thing is something that has never been a part of the material spec, I think we added it in as custom logic:
https://github.com/home-assistant/frontend/blob/dev/src/components/ha-clickable-list-item.ts#L29

I will set the "interactive" on the lists where possible and see if I can make it have the right ARIA roles. It's also something we can set as an attribute as far as I'm aware.

[steverep]

The spacebar thing is something that has never been a part of the material spec, I think we added it in as custom logic:

Material is irrelevant; it is part of W3C guidelines and best practices.

I will set the "interactive" on the lists where possible and see if I can make it have the right ARIA roles. It's also something we can set as an attribute as far as I'm aware.

The interactive attribute was removed in favor of the type attribute, and I've already tried that.

[silamon]

I've had a look at bringing this back to undrafting but the accessilbility issues are not easy to fix since I'm not sure where I can read about those guidelines. I found that spacebar should expand or unexpand the list of a menu button, which it does. At this time we're sure that accessibility is unacceptable with the current m3 implementation? How is the current implementation accessible of the ha-clickable-list-item component or are there problems with that implementation as well?

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.