Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity-filter editor config #20792

Closed
wants to merge 2 commits into from

Conversation

Quentame
Copy link
Member

Proposed change

Add entity-filter editor config

TODO:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@Quentame Quentame force-pushed the add/entity-filter-editor branch from a7cb757 to 4171bb3 Compare May 31, 2024 15:36
@Quentame Quentame force-pushed the add/entity-filter-editor branch from 4171bb3 to c18948a Compare June 14, 2024 18:22
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 12, 2024
@silamon silamon removed the stale label Sep 14, 2024
@bramkragten bramkragten requested a review from piitaya September 25, 2024 11:10
@piitaya
Copy link
Member

piitaya commented Sep 25, 2024

The condition editor would certainly need some adaption :

  • screen and user condition doesn't make sense for filtering entities as you can use the visibility option for that.
  • condition editor should support entity set to none because the entity will be provided by the card. Not sure how we can handle this case.

@frenck
Copy link
Member

frenck commented Nov 13, 2024

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

../Frenck

@frenck frenck closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants