Modify the way the update shows available updates #20773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @nielsnl68
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
piitaya
requested changes
May 22, 2024
Co-authored-by: Paul Bottein <[email protected]>
nielsnl68
commented
May 22, 2024
nielsnl68
commented
May 22, 2024
piitaya
previously approved these changes
May 22, 2024
piitaya
reviewed
May 22, 2024
piitaya
approved these changes
May 22, 2024
|
thanks for the merge :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
When the Update display is shown, the top section shows the new version number. To me it looks as if that is the current version.
Showing the new version was already shown double.
Proposed change
This PR will change this by showing "Update Available" instead.
into:
Type of change
Example configuration
No Change in configuration scripts needed.
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: