Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance webpack transform async plugin to use babel runtime (with fix) #20745

Merged
merged 1 commit into from
May 6, 2024

Conversation

steverep
Copy link
Member

@steverep steverep commented May 6, 2024

Proposed change

Retry of #20543 without my bonehead mistake that caused #20697.

See steverep/transform-async-modules-webpack-plugin#54 for the actual fix, which just adds .default when requiring the helpers. I was testing back and forth with HA using installs straight from GH and clearly forgot a final update somewhere. 😞

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Build Related to building the code label May 6, 2024
@steverep
Copy link
Member Author

steverep commented May 6, 2024

@piitaya thanks for posting the stack trace. Feel free to double check this on actual hardware if you can, but I could repro on modern browsers just by forcing the legacy build.

@silamon thanks for bisecting the issue.

@piitaya
Copy link
Member

piitaya commented May 6, 2024

Thank you! I will test on Safari 12 🙂

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works using iPad with iOS 12.

@steverep steverep merged commit 79cdc43 into dev May 6, 2024
14 checks passed
@steverep steverep deleted the fix-tamp-require branch May 6, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Related to building the code cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants