Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert usage of babel runtime for legacy bundle #20741

Merged
merged 1 commit into from
May 6, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented May 6, 2024

Proposed change

Revert the usage of babel runtine for es5 build introduced in #20543 because it breaks dashboard and some config screen in iOS 12.
I reverted the changes so we can have a fix for the patch release. We can provide a better support in the next release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2024.5 milestone May 6, 2024
@github-actions github-actions bot added the Build Related to building the code label May 6, 2024
@silamon silamon changed the title Revert usage of babel runtine for legacy bundle Revert usage of babel runtime for legacy bundle May 6, 2024
@silamon silamon merged commit bc41de0 into dev May 6, 2024
14 checks passed
@silamon silamon deleted the fix_es5_build_ios_runtime branch May 6, 2024 10:12
bramkragten pushed a commit that referenced this pull request May 6, 2024
Revert usage of babel runtine for legacy bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Related to building the code cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while loading page lovelace. on 2024.5.0
3 participants