Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ungrouped group when there are results #20716

Merged
merged 1 commit into from
May 6, 2024

Conversation

silamon
Copy link
Contributor

@silamon silamon commented May 3, 2024

Proposed change

When there are results in the "ungrouped" group and it's collapsed, the results are filtered away upon search when there are results to show. This changes the grouping to show the "ungrouped" group if there are results to show. See the issue for another example.

Edit: Since the original issue got cleaned up somehow, have 2 automations with a different name whereof one is assigned to a category referred to the first automation and one unassigned being the second automation. Then do the following:

  • nothing collapsed: search first automation will show first automation and search second automation will show second automation
  • collapse the category: search first automation will show first automation and search second automation will show second automation
  • collapse the ungrouped group: search first automation will show first automation and search seconds automation will not show second automation

This behavior is somewhat annoying when you're assigned categories to ungrouped automations because you want to collapse it so you don't see all the ungrouped automations but want to search for one to assign it to a category.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes _ #20672
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon silamon added this to the 2024.5 milestone May 3, 2024
@bramkragten bramkragten merged commit 8b220ac into home-assistant:dev May 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_
2 participants