Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make allow attribute configurable in iframe dashboards #20709

Closed
wants to merge 1 commit into from

Conversation

cvpcs
Copy link

@cvpcs cvpcs commented May 2, 2024

Breaking change

Proposed change

This expands upon #19087 by adding configuration to the iframe strategy for dashboards to support setting allow at the dashboard level and flowing the configuration into the iframe card.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: iframe
url: https://esphome.localhost
allow: serial

Additional information

This can be useful when enabling integrations as dashboards that require additional feature support (e.g. an esphome iframe and the serial port feature).

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cvpcs

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@piitaya
Copy link
Member

piitaya commented May 6, 2024

User can take control of the dashboard and already add the option, right? I don't think it's necessary to bring card options at the strategy level.

@bramkragten
Copy link
Member

I agree with @piitaya

@bramkragten bramkragten closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants