Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small reorganization of profile settings #20076

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Mar 12, 2024

Proposed change

Proposing a small reorganization of profile settings, as I think it confuse some users that some settings are global and some settings are local to the client only, and they are interspersed and not really elaborated which is which.

This change splits the current settings card into three:

Create a top card with the login message, and move the logout button here as I think it makes logical sense to pair with the login message.
Create a second card of settings which are global for the user, and explains this.
Create a third card of settings which are local to the client only, and explains this.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob
Copy link
Member

balloob commented Mar 13, 2024

This is awesome. You are a hero! 🥇

Can we push it a bit further?

  • Move all the authentication cards to a new page. The new page can either be a tab, or, we can add a list-item above the "LOGOUT" button that links to the authentication page. Not sure what would look better.
  • Rename card title "Refresh tokens" to "User Sessions".
  • Client settings -> Use isExternal() to make the title be "Mobile app settings" or "Browser settings"

@karwosts
Copy link
Contributor Author

Client settings -> Use isExternal() to make the title be "Mobile app settings" or "Browser settings"

This is implemented.

The other two suggestions I'm not sure if I want to take on at this point, I think those are a bit out of the scope of this change.

@balloob balloob merged commit 56a23c5 into home-assistant:dev Mar 14, 2024
13 checks passed
@karwosts karwosts deleted the profile-settings-reorg branch March 14, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants