Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the system default cursor in Safari #20072

Closed

Conversation

klaaspieter
Copy link

Proposed change

The section header title showed an l-beam cursor giving the false impression that the title is editable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The section header title showed an l-beam cursor giving the false
impression that the title is editable.
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @klaaspieter

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft March 12, 2024 16:54
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@klaaspieter klaaspieter marked this pull request as ready for review March 12, 2024 16:55
@bramkragten
Copy link
Member

That is the default cursor for all text that can be selected, it doesn't indicate it is editable.

@klaaspieter
Copy link
Author

@bramkragten fair. There is a discrepancy between Safari and other browsers though. The behavior caught me out in Safari because somehow the edit mode communicates that it should be editable.

Perhaps the better solution is to open the edit modal when the text is clicked? If not then what do you think I should do next? I don't have strong feelings; I'm fine with closing this. I just figured it a good first issue to tackle 😁

@frenck
Copy link
Member

frenck commented Mar 13, 2024

Safari because somehow the edit mode communicates that it should be editable.

I think you are confusing editable with selectable.

@piitaya
Copy link
Member

piitaya commented Mar 18, 2024

I'll close this one as it's not the proper fix. Thank you for reporting the issue.
Sections are still experimental so editor surely needs some improvements 🙂 We will take your feedback into account for next iteration.

@piitaya piitaya closed this Mar 18, 2024
@klaaspieter klaaspieter deleted the fix-safari-section-cursor branch March 19, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section title shows l-beam cursor in Safari
4 participants