Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL fixes for state info #20056

Merged
merged 3 commits into from
Mar 13, 2024
Merged

RTL fixes for state info #20056

merged 3 commits into from
Mar 13, 2024

Conversation

yosilevy
Copy link
Contributor

Breaking change

Proposed change

RTL fixes for state info

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@yosilevy yosilevy requested a review from piitaya March 11, 2024 14:30
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the previous margin for browsers that doesn't support these properties?

src/state-summary/state-card-alert.ts Outdated Show resolved Hide resolved
src/state-summary/state-card-toggle.ts Outdated Show resolved Hide resolved
@yosilevy
Copy link
Contributor Author

@piitaya Done although I do think some people added code that didn't do this. I can look around and see if I find any.

@piitaya piitaya merged commit 4ab0047 into home-assistant:dev Mar 13, 2024
13 checks passed
@yosilevy yosilevy deleted the RTL-fixes-9 branch September 24, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants