Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make migration warning alert sticky at the top for views #19970

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Mar 4, 2024

Proposed change

So it's always displayed in yaml and UI views.
I also tweaked the rules to allow user to migrate using yaml if they want. The view doesn't have to be empty but compatible (sections views must not have cards and other views must not have sections).

CleanShot 2024-03-04 at 11 37 23

CleanShot 2024-03-04 at 11 37 06

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2024.3 milestone Mar 4, 2024
@bramkragten bramkragten merged commit 70146a0 into dev Mar 4, 2024
14 checks passed
@bramkragten bramkragten deleted the fix_incompatible_view_alert branch March 4, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants