Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cancel button on edit view dialog #19821

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Feb 17, 2024

Proposed change

The cancel button is clicked when "enter" key is used the keyboard because the button was in the primary slot.
We have a close button at the top left so the cancel button is not needed anymore.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 4de3db5 into dev Feb 18, 2024
14 checks passed
@balloob balloob deleted the remove-edit-view-dialog-cancel branch February 18, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants