Improve service filtering #19811
Merged
Improve service filtering #19811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split filter term by space and match if each word is individually present
karwosts
reviewed
Feb 16, 2024
Co-authored-by: karwosts <[email protected]>
malkstar
commented
Feb 16, 2024
bramkragten
reviewed
Feb 27, 2024
| ); | ||
| const split_filter = filter.split(" "); | ||
| return processedServices.filter((service) => { | ||
| const lower_service_name = service.name.toLowerCase(); |
There was a problem hiding this comment.
service.name is marked optional in the original code, was that an error?
There was a problem hiding this comment.
I think so, any processedServices from here will always have a string with at least : in.
bramkragten
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I've always struggled with filtering this list, you have to match the service name or code exactly to get it to show up.
With this change it has a lot smoother UX, for instance "cloud disconnect" and "google tts" matches where it previously didn't.
Type of change
Example configuration
Go to developer tools > services and type words in any order to match services easier.
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: