Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconfigure config entry #19794

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Feb 13, 2024

Proposed change

This adds ability to reconfigure a config entry by explicitly running the async_step_reconfigure step.
Core PR: home-assistant/core#108794

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Demo Related to frontend demo content Design Related to Home Assistant design gallery labels Feb 13, 2024
@@ -3896,6 +3896,7 @@
"delete_confirm_title": "Delete {title}?",
"delete_confirm_text": "Its devices and entities will be permanently deleted.",
"enable_debug_logging": "Enable debug logging",
"reconfigure": "Reconfigure",
Copy link
Member

@frenck frenck Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the step is called reconfigure, but from a user perspective, I think it is really confusing.

This shows best I guess:

CleanShot 2024-02-14 at 18 40 34

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not the same as "Configure" is the options flow but "Reconfigure" is the reconfigure step within the config flow.
Not sure why "Configure" isn't actually called "Options" but anyhow yes, we need to think of some naming here or it might be confusing what's what.

Copy link
Member

@frenck frenck Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not the same as "Configure" is the options flow but "Reconfigure" is the reconfigure step within the config flow.

I have the context, hence me raising it 😉

Not sure why "Configure" isn't actually called "Options" but anyhow yes, we need to think of some naming here or it might be confusing what's what.

Honestly, I personally think that is the solution. Renaming existing "Configure" to "Options".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure it actually was called "Options" back in the days somewhere so not sure why it was renamed but I prefer also "Options" as the go to solution here. Thanks 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now updated the screenshot in the PR description to also include the change from "Configure" to "Options" for config entry options.

@gjohansson-ST gjohansson-ST added the backend merged The backend PR for this frontend PR has been merged label Mar 1, 2024
@bramkragten bramkragten merged commit 8b77024 into home-assistant:dev Mar 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend merged The backend PR for this frontend PR has been merged cla-signed Demo Related to frontend demo content Design Related to Home Assistant design gallery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants