-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reconfigure config entry #19794
Add reconfigure config entry #19794
Conversation
@@ -3896,6 +3896,7 @@ | |||
"delete_confirm_title": "Delete {title}?", | |||
"delete_confirm_text": "Its devices and entities will be permanently deleted.", | |||
"enable_debug_logging": "Enable debug logging", | |||
"reconfigure": "Reconfigure", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not the same as "Configure" is the options flow but "Reconfigure" is the reconfigure
step within the config flow.
Not sure why "Configure" isn't actually called "Options" but anyhow yes, we need to think of some naming here or it might be confusing what's what.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not the same as "Configure" is the options flow but "Reconfigure" is the reconfigure step within the config flow.
I have the context, hence me raising it 😉
Not sure why "Configure" isn't actually called "Options" but anyhow yes, we need to think of some naming here or it might be confusing what's what.
Honestly, I personally think that is the solution. Renaming existing "Configure" to "Options".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure it actually was called "Options" back in the days somewhere so not sure why it was renamed but I prefer also "Options" as the go to solution here. Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now updated the screenshot in the PR description to also include the change from "Configure" to "Options" for config entry options.
c8bab0e
to
a8d8c65
Compare
Proposed change
This adds ability to reconfigure a config entry by explicitly running the
async_step_reconfigure
step.Core PR: home-assistant/core#108794
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: