-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate blueprint editor code #19791
Deduplicate blueprint editor code #19791
Conversation
</p>`}` | ||
: ""} | ||
</ha-card> | ||
${this.renderCard()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this could have been a separate element taking config
and blueprints
as a parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, yeah I can see that might have been a good alternative, I hadn't considered it.
I'd probably rather not spend the time to go reimplement this again though, unless you truly don't like this approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like base classes as it can be confusing what happens where... I'm ok for it now though :-)
Proposed change
The blueprint editor for script and automation are 90% the same, but the code is duplicated, requiring making edits to both files for any change. Deduplicate with inheritance. No functional change.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: