Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate blueprint editor code #19791

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

karwosts
Copy link
Contributor

Proposed change

The blueprint editor for script and automation are 90% the same, but the code is duplicated, requiring making edits to both files for any change. Deduplicate with inheritance. No functional change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

</p>`}`
: ""}
</ha-card>
${this.renderCard()}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could have been a separate element taking config and blueprints as a parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, yeah I can see that might have been a good alternative, I hadn't considered it.

I'd probably rather not spend the time to go reimplement this again though, unless you truly don't like this approach.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like base classes as it can be confusing what happens where... I'm ok for it now though :-)

@bramkragten bramkragten merged commit 291638a into home-assistant:dev Feb 28, 2024
13 checks passed
@karwosts karwosts deleted the generic-blueprint-editor branch February 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants