Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install libpcap for core in devcontainers #19787

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Install libpcap for core in devcontainers #19787

merged 1 commit into from
Feb 14, 2024

Conversation

steverep
Copy link
Member

Proposed change

aiohttp complains about this missing library when running core script. I've always installed manually but this is better obviously.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon
Copy link
Contributor

silamon commented Feb 13, 2024

I never noticed that. The only thing that I miss is the backend translations from integrations which I can add with:
(cd "$HOME/src/homeassistant" && python3 -m script.translations develop --all)

@steverep
Copy link
Member Author

I never noticed that. The only thing that I miss is the backend translations from integrations which I can add with: (cd "$HOME/src/homeassistant" && python3 -m script.translations develop --all)

We could add that to the core script.

@bramkragten bramkragten merged commit 226dad3 into dev Feb 14, 2024
14 checks passed
@bramkragten bramkragten deleted the install-libpcap branch February 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants