Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lovelace card events #19785

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Improve lovelace card events #19785

merged 1 commit into from
Feb 14, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Feb 12, 2024

Proposed change

Add typings for event listeners :

  • add card event requires view index
  • edit card event requires view index and card index
  • delete card event requires view index and card index

Refactor showEditCardDialog parameters to better understand the logic with optional config passed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 33cdd51 into dev Feb 14, 2024
14 checks passed
@bramkragten bramkragten deleted the improve_ll_card_event branch February 14, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants