Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to energy dashboard for when preferences are empty #19765

Merged
merged 4 commits into from
May 13, 2024

Conversation

codyc1515
Copy link
Contributor

Proposed change

  • Forbid completing energy dashboard setup unless at least one statistic is selected
  • If energy setup was completed but there are no sources available, start setup wizard again

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codyc1515 codyc1515 changed the title Energy_empty Add checks to energy dashboard for when preferences are empty Feb 10, 2024
@codyc1515 codyc1515 marked this pull request as ready for review February 10, 2024 23:12
@silamon silamon merged commit 099ea61 into home-assistant:dev May 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants