Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cast launch screen colors #19754

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Update cast launch screen colors #19754

merged 4 commits into from
Mar 4, 2024

Conversation

jeremynoesen
Copy link
Contributor

Proposed change

Change the background color and the text color of the cast launch screen to match that of the Home Assistant branding. The first image is what the screen looks like now (background white, text black), and the second image is what this PR will make it look like (background f2f4f9, text 1d2126). This will also fix the fact that the "white" in the Home Assistant logo is different from the white background, which also fills in the Nabu Casa logo.

Screenshot 2024-02-09 at 1 46 56 PM
Screenshot 2024-02-09 at 1 46 31 PM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • [NA] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Cast Related to Home Assistant Cast UI label Feb 9, 2024
@jeremynoesen
Copy link
Contributor Author

jeremynoesen commented Feb 9, 2024

If #19748 happens to get merged, and this also gets merged, there might be some conflicts, since the mentioned PR deletes the .status css block, while this one uses it.

Edit: The merge conflicts have been resolved.

@jeremynoesen
Copy link
Contributor Author

I think the CI / Build supervisor (pull_request) check got stuck.

@jeremynoesen
Copy link
Contributor Author

I would appreciate if someone could take a look at this. It is a subtle change, but it makes the launch screen look more polished.

@bramkragten
Copy link
Member

@jeremynoesen I'll merge this for now, the reason it was not merged yet is because there is a complete new design for the launch screen that will be implemented soon.

@bramkragten bramkragten merged commit 05e2e30 into home-assistant:dev Mar 4, 2024
13 checks passed
@bramkragten bramkragten added this to the 2024.3 milestone Mar 4, 2024
@jeremynoesen
Copy link
Contributor Author

@jeremynoesen I'll merge this for now, the reason it was not merged yet is because there is a complete new design for the launch screen that will be implemented soon.

I'm looking forward to it! Sorry to seem pushy with this PR, I had no clue that was in the works 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cast Related to Home Assistant Cast UI cherry-picked cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants