Filter unrecorded entities from history panel

[karwosts]

Proposed change

Don't show unrecorded entities in the history panel target picker.

Could probably expand this to more places (logbook, history graph card, alert in more-info dialog), but just starting simple for a proof of concept.

Requires home-assistant/core#92640

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion: https://discord.com/channels/330944238910963714/1202651481099083917
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[bramkragten]

This means new entities will never show up, I don't think we should do this, it will cause users to wonder why their new entity is not showing up in the picker...

[karwosts]

Oof, right. Maybe invert the list when we fetch it, and cache the list of things which are currently excluded?

I didn't start with caching, but I thought it would be nice as this could be kind of a big list to retrieve repeatedly, and it doesn't change much in a meaningful way (at least without someone editing their config.yaml and restarting).

Maybe also inquire about inverting the polarity of the API, to fetch excluded entities instead of recorded ones. I feel like that's generally going to be a much smaller list in the average usecase.

[bramkragten]

I think it might be easier to just get the filters that are set by the user in config, we can then use

frontend/src/common/entity/entity_filter.ts

Line 19 in 8cad37a

export const generateFilter = (

to filter the entities...

[karwosts]

Maybe leave that comment in the core thread so we can collect all the ideas in one place?

I do kind of like that we're now getting visibility into exactly what the backend thinks is recorded, instead of reproducing the filtering logic ourselves, as we've already identified a bug as a result of that. But this could work too.

[bramkragten]

Yeah, we don't support things like globs in frontend...

[karwosts]

Ok flipped the logic around a bit. I still cache the result, but at the moment I get back the api response, I also cache a list of any entity that is present in hass.states, but not in the recorded response. And then use that to exclude from the picker.

So any new entities created after the cache was fetched would not be excluded.

bdraco also suggested we can use this information to populate the picker with entities which are orphaned/missing from the states table, but still have history in the database. Haven't done that yet, but the plumbing is there to do so.

I think hass.states is the right thing to check against right? I don't need to do anything additionally with entity registry?

[bramkragten]

I think hass.states is the right thing to check against right? I don't need to do anything additionally with entity registry?

Yeah that should be fine 👍

[Mariusthvdb]

Proposed change

Don't show unrecorded entities in the history panel target picker.

Could probably expand this to more places (logbook, history graph card, alert in more-info dialog),

just letting you know the latter there was the whole reason for our custom plugin custom-more-info.... filter those empty placeholders for History and Logbook..which show on entities that are not recorded in the first place.

If core would do that, that would be awesome indeed.

Also, Ive chatted about 'importing' the HA recorder settings into our plugin, but, as that is a pure Frontend thing, it doesnt read the backend recorder settings....

maybe this new PR can change that at some point. Or, make it unnecessary, which would be even better.

[ildar170975]

Currently History panel can show a history for not-recorded entity - if the entity is changing while the History view is open.
For instance, this entity is excluded from Recorder - yet we can see it's "streamlined" data realtime:

Disabling a possibility to select a not-recorded entity will kill this feature.
If you about to filter a list - suggest to add a checkbox like "show only recorded" ("on" by default).

Btw, a possibility to show history for not-recorded entities is also available in more-info:

And keeping this possibility for a History view could be rather useful for monitoring.

[karwosts]

Currently History panel can show a history for not-recorded entity - if the entity is changing while the History view is open. For instance, this entity is excluded from Recorder - yet we can see it's "streamlined" data realtime:
Disabling a possibility to select a not-recorded entity will kill this feature. If you about to filter a list - suggest to add a checkbox like "show only recorded" ("on" by default).

Believe you can still type any entity id manually in the dropdown in history to keep the current behavior, it just won't be populated in the dropdown list for easy picking.

[ildar170975]

still type any entity id manually

Better than nothing.