Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean domain icons #19533

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Clean domain icons #19533

merged 7 commits into from
Jan 30, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jan 25, 2024

Proposed change

Add ha-domain-icon icon and remove (almost) all icon rules from the frontend repo.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya force-pushed the clean_domain_icons branch from eb45d14 to 4ab098f Compare January 25, 2024 21:45
@piitaya piitaya added the Do Not Review PR is not ready for any kind of review label Jan 25, 2024
@piitaya piitaya force-pushed the clean_domain_icons branch from 4ab098f to 677d4ad Compare January 25, 2024 22:10
@piitaya piitaya force-pushed the clean_domain_icons branch from 677d4ad to e947e01 Compare January 29, 2024 10:30
@piitaya piitaya force-pushed the clean_domain_icons branch from 15a47c2 to 935f378 Compare January 29, 2024 11:19
@piitaya piitaya marked this pull request as ready for review January 29, 2024 11:22
@piitaya piitaya removed the Do Not Review PR is not ready for any kind of review label Jan 29, 2024
@piitaya piitaya requested a review from bramkragten January 29, 2024 11:22
@piitaya piitaya force-pushed the clean_domain_icons branch from 935f378 to 68d5a07 Compare January 29, 2024 11:35
Co-authored-by: Bram Kragten <[email protected]>
@bramkragten bramkragten merged commit 3144990 into dev Jan 30, 2024
13 checks passed
@bramkragten bramkragten deleted the clean_domain_icons branch January 30, 2024 13:49
@karwosts

This comment was marked as outdated.

@karwosts

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants