-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix step any in number selector #19077
Conversation
1, | ||
(this.selector.number!.max! - | ||
this.selector.number!.min!) / | ||
100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 100 arbitrary? What was the behavior for the old slider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a choice from me, to make it 100 steps if it is not specified. I think the old one did something similar, let me check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the old one would set the step to 1, but that makes no sense if the max is below 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, it should be 1, 0.1, 0.01, etc... based on the min/max.
Because, by only dividing by 100, if you have min = 0 and max = 1.2, you will have 0.012 and it doesn't make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, updated
Proposed change
Step
any
was broken in the slider.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: