Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix step any in number selector #19077

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

Step any was broken in the slider.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

1,
(this.selector.number!.max! -
this.selector.number!.min!) /
100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 100 arbitrary? What was the behavior for the old slider?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a choice from me, to make it 100 steps if it is not specified. I think the old one did something similar, let me check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the old one would set the step to 1, but that makes no sense if the max is below 1.

Copy link
Member

@piitaya piitaya Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it should be 1, 0.1, 0.01, etc... based on the min/max.
Because, by only dividing by 100, if you have min = 0 and max = 1.2, you will have 0.012 and it doesn't make sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, updated

@bramkragten bramkragten merged commit 325ad6f into dev Dec 18, 2023
13 checks passed
@bramkragten bramkragten deleted the fix-step-any-in-number-selector branch December 18, 2023 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants