Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit Area dialog doesn't save area #18659

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Nov 14, 2023

Proposed change

Changes primaryAction to secondaryAction for the cancel button so the cancelAction doesn't get executed when enter is pressed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@piitaya piitaya merged commit b35e5ab into home-assistant:dev Nov 15, 2023
13 checks passed
@balloob
Copy link
Member

balloob commented Nov 16, 2023

Thanks @silamon 🐬

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing enter in Edit Area dialog doesn't save area
3 participants