Add new dashboard dialog #18657
Merged
Add new dashboard dialog #18657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
force-pushed
the
new_dashboard_dialog
branch
from
9dbfd30 to
234d1d6
Compare
balloob
reviewed
Nov 16, 2023
src/translations/en.json
Outdated
| "header": "Add dashboard", | ||
| "create_empty": "New dashboard from scratch", | ||
| "create_empty_description": "Start with an empty dashboard from scratch", | ||
| "default": "Overview dashboard", |
There was a problem hiding this comment.
I would either go more generic or more specific:
- Call it "default dashboard" and we can upgrade it in the future to new defaults
- Call it "Masonry Dashboard" because it's tied to the layout engine that's used
balloob
reviewed
Nov 16, 2023
bramkragten
reviewed
Nov 16, 2023
| <ha-icon-next slot="meta"></ha-icon-next> | ||
| </ha-list-item> | ||
| <li divider role="separator"></li> | ||
| <ha-list-item |
There was a problem hiding this comment.
Next step would be for strategies to register like custom cards do and loop over that here right?
piitaya
force-pushed
the
new_dashboard_dialog
branch
from
234d1d6 to
1cac1c0
Compare
bramkragten
approved these changes
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add new dashboard dialog with similar UX than automation and script. The user can now directly start with an empty dashboard.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: