Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lovelace types #18652

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Improve Lovelace types #18652

merged 5 commits into from
Nov 15, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Nov 14, 2023

Proposed change

Split lovelace types and utils into multiple files.

Introduce LovelaceRawConfig type to make a difference between raw configuration provided by the user and configuration to build the dashboard (this configuration can be computed using strategy). Same goes for LovelaceViewRawConfig type.
This change showed problems when casting a strategy dashboard to a cast devices. It's fixed with that PR too.
views property are no more required when using a strategy.

rawConfig is now required in the lovelace object. The default dashboard now injects a raw configuration (it was previously undefined) and configuration. The default dashboard is now handle as any strategy in term of configuration so it will be easier to add options for this default strategy or allow user to take control of any strategy.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Cast Related to Home Assistant Cast UI Demo Related to frontend demo content Design Related to Home Assistant design gallery labels Nov 14, 2023
@piitaya piitaya marked this pull request as ready for review November 14, 2023 13:34
@frenck frenck merged commit 1cf928b into dev Nov 15, 2023
13 checks passed
@frenck frenck deleted the lovelace_types branch November 15, 2023 10:13
@piitaya piitaya mentioned this pull request Nov 15, 2023
9 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Cast Related to Home Assistant Cast UI cla-signed Demo Related to frontend demo content Design Related to Home Assistant design gallery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants