Add translations for the developer tools statistic issues #18646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Nov 16, 2023
src/panels/developer-tools/statistics/dialog-statistics-adjust-sum.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 16, 2023
src/panels/developer-tools/statistics/dialog-statistics-adjust-sum.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 16, 2023
src/panels/developer-tools/statistics/dialog-statistics-adjust-sum.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 16, 2023
src/panels/developer-tools/statistics/dialog-statistics-adjust-sum.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 16, 2023
| "no_statistics_found": "No statistics found for this period.", | ||
| "info_text_1": "Sometimes the statistics end up being incorrect for a specific point in time. This can mess up your beautiful graphs! Select a time below to find the bad moment and adjust the data.", | ||
| "pick_a_time": "Pick a time", | ||
| "statistic": "Statistic:", |
There was a problem hiding this comment.
Move the column out of the translation and in the template, or (prefer) make the statistic id a variable:
Statistic: {statistic}
There was a problem hiding this comment.
It's being placed in bold like this:
Statistic: statistic_id
Therefore I had to split it.
I can go ahead and take the bold out as well?
There was a problem hiding this comment.
I see we have this a lot in our translation files, so am gonna merge.
bramkragten
approved these changes
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Include translations for the statistical issues in the developer tools. Occasionally, links are embedded within sentences. To simplify translations and avoid unnecessary complexity, the entire sentence is now treated as a link.
I have also activated the previously disabled lit rules in these files and updated the terminology to use 'delete' instead of 'remove.'
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: