Localization bugfixes in config devices/entities/helpers #18645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix two issues in config data tables:
1.
Occasionally on refresh devices and entities table render without header labels:
There was a race condition where the columns were being memoized with the initial dummy localization function, and never refreshed when hass.localize updated. This adds the function pointer to the memoize function.
2.
The integration column in Entities table, and the type column in Helpers table, were applying sort/filter on the backend integration name, but displaying the pretty/translated name, which makes the sort and filter behave unexpectedly.
For example, you can have helpers which have the type "Combine the state of several entities". If you search for "combine", you will have no results, because the row is actually comparing against
min_max
, which no one would ever guess to type. Also it makes "Combine" sort alphabetically after "M" which is unexpected. Similar problems withDropdown
,Riemann
,Toggle
, etc.This changes the table logic to sort and filter on the displayed text, not the pre-translation value.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: