Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live camera & custom AR to Area card #18643

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Nov 13, 2023

Proposed change

Allow area card to use live camera stream like the other picture type cards can do.

Can't think of any reason not to allow this.

Also allow a custom aspect ratio for area card, in case the camera stream does not fit nicely for 16:9.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

This should be added to the type AreaCardConfig

And should probably also be added to the editor and struct?

@karwosts
Copy link
Contributor Author

I'm happy to update the UI editor to include these if desired, just wanted to check that this option was approved before doing so.

@karwosts
Copy link
Contributor Author

Updated the editor. camera_view field is conditionally shown if show_camera is enabled. I also realized that aspect ratio was not respected for area cards without an image or camera, I so fixed area card to support that.

image

@bramkragten bramkragten merged commit a45eefa into home-assistant:dev Nov 18, 2023
13 checks passed
@karwosts karwosts deleted the area-camera branch November 18, 2023 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lovelace Area Card - Show live view as background not woring
2 participants