Fix login password form

[karwosts]

Proposed change

Broke from #18607

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[piitaya]

Thanks for the fix.
I think we should have a proper way to use ha-form without hass. Some other form elements have the same issue but we don't use them in onboarding so we don't have the issue yet.

[OACDesigns]

Hi @karwosts, I just noticed that on the onboarding screen the password field is still missing.
It looks like this fix only targets the password field in the login form, but the original MR #18607 where the issue was introduced also included changes to ha-selector-text.ts file.
Perhaps you missed it?

[karwosts]

I didn't realize onboarding used a different form element than login for password, so I didn't think that selector-text needed the same fix. I'll PR the same for selector-text.

[karwosts]

@OACDesigns - any chance you could test if #18665 resolves the problem? I don't have a setup to run onboarding flow at the moment.

[OACDesigns]

Hi, to be honest I'm not exactly sure how to do that...
I only came across this because I'm learning how to do addon development and was using the addon devcontainer which seems to use the latest frontend.

Do you know anything the devcontianers and how I might be able to point it to using your branch?

[karwosts]

No problem, don't worry about it.

Sorry I don't know how to give you instructions for that at the moment, since I don't use the containers for frontend.