Add number tile feature #18562
Add number tile feature #18562
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Paul Bottein <[email protected]>
| private async _setValue(ev: CustomEvent) { | ||
| const stateObj = this.stateObj!; | ||
|
|
||
| await this.hass!.callService("input_number", "set_value", { |
There was a problem hiding this comment.
I think that for number domain the service that should be called is number.set_value
There was a problem hiding this comment.
Yes, I just added that domain so I hadn't tested it yet, good catch.
src/panels/lovelace/editor/config-elements/hui-tile-card-features-editor.ts
Show resolved
Hide resolved
| private async _setValue(ev: CustomEvent) { | ||
| const stateObj = this.stateObj!; | ||
|
|
||
| const domain = computeDomain(stateObj.entity_id); |
There was a problem hiding this comment.
can we computeDomain once or memoize it? Now it is calculated every time we want to change the value.
There was a problem hiding this comment.
I don't think this will change something because computeDomain is a very simple function and it will make the code complicated. Memoization must be used for large computing like transforming array or computing complex object.
Adding memoization here will be worst because it will introduce multiple checks to compute the value.
There was a problem hiding this comment.
This function also only runs on change not on render so it won't run that often.
|
@JosephAbbey is this ready to review? |
|
Thank you ! Ok for me ! |
Proposed change
Number Input (buttons or slider)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: