Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify logos #18542

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Minify logos #18542

merged 2 commits into from
Nov 7, 2023

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Nov 5, 2023

Proposed change

The SVG logo is surprisingly unminified. This PR minifies it in most places.

Type of change

Bugfix

No configuration, issues, discussions, or pull requests is relevant

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@github-actions github-actions bot added the Demo Related to frontend demo content label Nov 5, 2023
Copy link
Member

@steverep steverep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these are minified in production builds. Are you looking at the dev build perhaps?

@KTibow
Copy link
Contributor Author

KTibow commented Nov 5, 2023

The auto-optimizations have a limit - mask-icon.svg and all path data aren't minified in the prod builds.
My optimizations are stuff that aren't auto-performed, like using arcs instead of curves.

@bramkragten
Copy link
Member

bramkragten commented Nov 6, 2023

The mask icon is changed, it has padding now, is this intentional?

@KTibow
Copy link
Contributor Author

KTibow commented Nov 6, 2023

It was semi-intentional, as I thought it would make more sense to replace the logo than minify it given that the current one has some not-so-smooth corners:
image
Should I edit the new one so it has no padding?

@bramkragten
Copy link
Member

Should I edit the new one so it has no padding?

Yes please

@bramkragten bramkragten merged commit aa0419e into home-assistant:dev Nov 7, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Demo Related to frontend demo content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants