Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate chips to Material 3 chips. #18513

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Migrate chips to Material 3 chips. #18513

merged 9 commits into from
Nov 9, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Nov 2, 2023

Proposed change

Use new Material 3 chips. Most chips has been replaced by M3 chips. Demo has been updated too.

Some chips are used as label or tags (in quick-bar, automation list, user dialog). They are migrated to a new component ha-label that doesn't have click action and hover state.

Old Material chip dependency is not removed because it's needed for target picker. We have to figure out how to move this one to M3 (in another PR).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview and removed cla-signed labels Nov 2, 2023
@github-actions github-actions bot added Supervisor Related to the supervisor panel Design Related to Home Assistant design gallery labels Nov 2, 2023
@silamon
Copy link
Contributor

silamon commented Nov 3, 2023

For what it is worth, there is also a material chip implementation in the target picker. Aside from the chip possibilities, this one has multiple icon buttons and a very custom css.

@piitaya
Copy link
Member Author

piitaya commented Nov 9, 2023

@silamon I checked to convert those chips to M3. M3 chips doesn't support 2 trainling actions (only remove action is possible). I will be for another PR because it's to much work for this one (e.g. we have to develop our own chips using M3 internals if we want this one)

@piitaya piitaya marked this pull request as ready for review November 9, 2023 08:32
@silamon
Copy link
Contributor

silamon commented Nov 9, 2023

@silamon I checked to convert those chips to M3. M3 chips doesn't support 2 trainling actions (only remove action is possible). I will be for another PR because it's to much work for this one (e.g. we have to develop our own chips using M3 internals if we want this one)

Yeah I agree, eventually it may fit better as a regular component not really tied to a m3 chip.

@piitaya piitaya marked this pull request as draft November 9, 2023 10:11
@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Nov 9, 2023
@piitaya piitaya marked this pull request as ready for review November 9, 2023 10:26
@github-actions github-actions bot removed the Dependencies Pull requests that update a dependency file label Nov 9, 2023
@JosephAbbey
Copy link
Contributor

The preview deployment does not seem to be working for this PR

@piitaya
Copy link
Member Author

piitaya commented Nov 9, 2023

@JosephAbbey Here's the link : https://deploy-preview-18513--home-assistant-gallery.netlify.app/#components/ha-chips

@bramkragten bramkragten merged commit 37b7395 into dev Nov 9, 2023
12 checks passed
@bramkragten bramkragten deleted the material-3-chips branch November 9, 2023 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Design Related to Home Assistant design gallery needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants