Add numeric state condition for conditional card #18288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Oct 23, 2023
| return false; | ||
| } | ||
|
|
||
| const numericState = Number(entity.state); |
There was a problem hiding this comment.
Should we check if the state is actually a number?
There was a problem hiding this comment.
Right! Because it can be unavailable even if it's not a number.
I will be NaN and the below or above condition will fail but I agree we should have a guard here.
bramkragten
reviewed
Oct 23, 2023
bramkragten
previously approved these changes
Oct 23, 2023
piitaya
force-pushed
the
conditional_card_numeric_state
branch
2 times, most recently
from
4cddd2c to
b046507
Compare
bramkragten
previously approved these changes
Oct 23, 2023
piitaya
force-pushed
the
conditional_card_numeric_state
branch
from
b046507 to
ddc9a73
Compare
bramkragten
previously approved these changes
Oct 23, 2023
bramkragten
approved these changes
Oct 23, 2023
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add numeric state condition for conditional card
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: