Load and set Polymer settings asynchronously #18278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steverep
commented
Oct 18, 2023
| import("@polymer/polymer/lib/utils/settings").then( | ||
| ({ setCancelSyntheticClickEvents, setPassiveTouchGestures }) => { | ||
| setCancelSyntheticClickEvents(false); | ||
| setPassiveTouchGestures(true); |
There was a problem hiding this comment.
Why is this being set anyway when preventDefault() is called all over the place?
There was a problem hiding this comment.
Those are mostly for click action and other events, not for touch events
bramkragten
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Similar to #18226 for
ha-style, there's no need for the Polymer settings module to be in every entrypoint blocking the component definitions. This loads it dynamically instead.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: