Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes alarm dialog inputmode for code input #18263

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

joshmcrty
Copy link
Contributor

Proposed change

This change ensures that the inputmode is set on the input field for the code entry dialog (for example to arm/disarm an alarm). Currently this is not set because of a hyphen in the attribute.

The inputmode is helpful particularly on mobile keyboards that change how they are displayed. For an alarm code that is all numbers, this PR will ensure that on supported devices a numeric keyboard (only digits) is shown instead of the full QWERTY keyboard.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Add an alarm entity with a number code to arm/disarm. Open the alarm dialog on a mobile device, then change the alarm arming status. This will display the code entry dialog. Click/tap on the input field and you should now see a numeric keyboard instead of the full qwerty keyboard on the mobile device.

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@joshmcrty joshmcrty force-pushed the fix-alarm-dialog-inputmode branch from 4257945 to 3309bdd Compare October 17, 2023 04:08
@piitaya
Copy link
Member

piitaya commented Oct 17, 2023

Thanks @joshmcrty 🙂 !

@piitaya piitaya merged commit b2cb0d8 into home-assistant:dev Oct 17, 2023
12 checks passed
@joshmcrty joshmcrty deleted the fix-alarm-dialog-inputmode branch October 24, 2023 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants