Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CORS for legacy bundle loading #18248

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Enable CORS for legacy bundle loading #18248

merged 2 commits into from
Oct 16, 2023

Conversation

steverep
Copy link
Member

Proposed change

Enables CORS mode for both the entry scripts and tags added by Webpack.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Build Related to building the code label Oct 15, 2023
@bramkragten
Copy link
Member

What is the reasoning behind this? Will this not give issues with custom ES5 modules like it did when we tried this for modules? #6745

@steverep
Copy link
Member Author

What is the reasoning behind this?

  1. My thought was so there are no restrictions on error logging, but disregard that as I see now it only applies when it's actually not the same origin
  2. So that if or when webpackPreload is used for the modern build, it works (i.e. <link rel="modulepreload" ... />)

Will this not give issues with custom ES5 modules like it did when we tried this for modules? #6745

Yeah, you're right it probably would. I'll remove that.

@steverep
Copy link
Member Author

Okay I removed it for custom scripts. So now it's on/off equivalent to the modern build.

@bramkragten bramkragten merged commit d88831b into dev Oct 16, 2023
12 checks passed
@bramkragten bramkragten deleted the enable-webpack-cors branch October 16, 2023 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build Related to building the code cla-signed hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants