Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace internal material/web usages #18219

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Oct 14, 2023

Proposed change

This was in the changelog of material/web package during the prereleases:
"Rename @material/web//lib to @material/web//internal. Prefer not using internal files."
There were already some imports at the time, and they were replaced with internal import back then.
I think it can be avoided using the changes in this PR, and allows us to stick closer to their public API.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

bramkragten
bramkragten previously approved these changes Oct 16, 2023
@bramkragten bramkragten merged commit b6fe0cf into home-assistant:dev Oct 16, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants