Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency lit to v3 #18209

Closed
wants to merge 1 commit into from
Closed

Update dependency lit to v3 #18209

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 13, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
lit (source) 2.8.0 -> 3.0.2 age adoption passing confidence

Release Notes

lit/lit (lit)

v3.0.2

Compare Source

Patch Changes
  • #​4345 02b8d620 - Add a dev mode warning if a static value such as literal or unsafeStatic is detected within the non-static html tag function. These should only be used with the static html tag function imported from lit-html/static.js or lit/static-html.js.

v3.0.1

Compare Source

Patch Changes
  • #​4240 edf998c9 Thanks @​remziatay! - Improved the type inferece of the choose() directive to properly restrict the case type inferred from provided value. Note: If this change creates a type error in your code, there must have been an unreachable case that can be removed, or the type of your value might be missing a valid case in the union.

  • #​4310 8f674ab3 Thanks @​megheaiulian! - The when() directive now calls the case functions with the provided condition value as an argument. This allows the narrowing of types for the condition value based on its truthiness when used as a parameter for the case function.

  • #​4284 89a5b088 - Allow null to be in the type of @query() decorated fields

v3.0.0

Compare Source

Major Changes
  • #​3756 f06f7972 - Drop IE11 support

  • #​4146 0f6878dc - Generated accessor for reactive properties now wrap user accessors and automatically call this.requestUpdate() in the setter. As in previous versions, users can still specify noAccessor: true, in which case they should call this.requestUpdate() themselves in the setter if they want to trigger a reactive update.

  • #​3765 92cedaa2 - Remove experimental hydrate modules. These are available from @lit-labs/ssr-client.

  • #​3850 7e8491d4 - Delete deprecated queryAssignedNodes behavior and arguments.

    Migrate deprecated usage with a selector argument to use
    @queryAssignedElements. E.g.: @queryAssignedNodes('list', true, '.item') to
    @queryAssignedElements({slot: '', flatten: false, selector: '.item'}).

  • #​4254 1040f758 - Change the type of ReactiveElement.renderRoot and return type of ReactiveElement.createRenderRoot() to be HTMLElement | DocumentFragment to match each other and lit-html's render() method.

  • #​3759 1db01376 - Use replaceWith() for SVG templates

  • #​3751 dfd747cf - Simplify lit-html attribute handling for standards-compliant browsers that iterate attributes in source order

  • #​3750 c3e473b4 - Use toggleAttribute() to simplify boolean attribute parts

  • #​3896 2eba6997 - Warn on async overrides of performUpdate()

Patch Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Dependencies Pull requests that update a dependency file label Oct 13, 2023
@KTibow
Copy link
Contributor

KTibow commented Oct 14, 2023

If I'm understanding the implications of the lint errors correctly this looks like a motivator to move to @material/web 👀

Well either that, a bunch of as any, or some other elegant solution I haven't thought of ¯\_(ツ)_/¯

@bramkragten
Copy link
Member

This will need a lot of work, as they dropped support for our current decorators and we will need a lot of changes to make the standard decorators work.

@renovate renovate bot force-pushed the renovate/lit-3.x branch 4 times, most recently from ffca434 to 2ea0353 Compare October 23, 2023 14:15
@renovate renovate bot force-pushed the renovate/lit-3.x branch 7 times, most recently from 69da0bb to 7bd60d4 Compare November 1, 2023 10:17
@KTibow
Copy link
Contributor

KTibow commented Nov 1, 2023

Also I'm not sure if this happens with the main HA build workflow, but in a test environment I found that when MWC is used with Lit 3, both Lit 3 and Lit 2 are duplicated many times throughout each bundle.

@renovate renovate bot force-pushed the renovate/lit-3.x branch from 7bd60d4 to d2bba58 Compare November 6, 2023 01:36
@steverep
Copy link
Member

steverep commented Nov 6, 2023

This will need a lot of work, as they dropped support for our current decorators and we will need a lot of changes to make the standard decorators work.

Yes, some other changes would be needed as well. Mostly though, I think we should give dependencies a chance to support lit 3:

The much higher priority IMO should be getting rid of Polymer and then MWC.

Closing this to prevent automatic rebases from eating up resources.

@steverep steverep closed this Nov 6, 2023
@steverep steverep deleted the renovate/lit-3.x branch November 6, 2023 19:05
Copy link
Contributor Author

renovate bot commented Nov 6, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants