Fix for RTL languages - Profile panel + weather forecast card #18191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzagim
changed the title
bramkragten
reviewed
Oct 12, 2023
| @@ -250,6 +250,7 @@ class HaPanelProfile extends LitElement { | |||
| max-width: 600px; | |||
| margin: 0 auto; | |||
| padding-bottom: env(safe-area-inset-bottom); | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
I see this issue and that this fixes it, I just have a hard time understanding why it happens, and why only in rtl...
bramkragten
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Added design compatibility for RTL languages for Profile panel and weather card
Type of change
Additional information
Fix temp location on weather card for RTL languages, Attached Image.
Before:
After:
Profile:
Checklist