Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate developer state tools to LitElement #18134

Merged
merged 10 commits into from
Oct 16, 2023
Merged

Migrate developer state tools to LitElement #18134

merged 10 commits into from
Oct 16, 2023

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Oct 6, 2023

Proposed change

Migrate the developer state tools from PolymerElements to LitElements
One problem remaining, see comment below

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

steverep
steverep reviewed Oct 7, 2023
View reviewed changes
Copy link
Member

@steverep steverep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let Bram or Paul take a closer look, but other than my few type notes, LGTM 👍🏻

PS - This is awesome work ridding HA of polymer and converting to TS... keep it up please! 👏🏻

src/panels/developer-tools/state/developer-tools-state.ts Show resolved Hide resolved
src/panels/developer-tools/state/developer-tools-state.ts Outdated Show resolved Hide resolved
src/panels/developer-tools/state/developer-tools-state.ts Outdated Show resolved Hide resolved
src/panels/developer-tools/state/developer-tools-state.ts Outdated Show resolved Hide resolved
steverep
steverep previously approved these changes Oct 13, 2023
View reviewed changes
@bramkragten bramkragten merged commit a08185a into home-assistant:dev Oct 16, 2023
12 checks passed
@karwosts karwosts mentioned this pull request Oct 23, 2023
Merged
9 tasks
@silamon silamon mentioned this pull request Oct 27, 2023
Merged
9 tasks
@piitaya piitaya mentioned this pull request Nov 9, 2023
Merged
9 tasks
@silamon silamon mentioned this pull request Nov 30, 2023
Merged
9 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bramkragten bramkragten bramkragten approved these changes

@steverep steverep steverep left review comments

Assignees
No one assigned
Labels
cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silamon @bramkragten @steverep