Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ha-form data lost if quick data updates #18094

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Oct 2, 2023

Proposed change

Firefox password manager set username and password in the same time. Two value-changed event were fired but this.data wasn't up-to-date. This PR updates this.data before the fire event so ha-form internal is up-to-date.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya merged commit a3400a2 into dev Oct 2, 2023
@piitaya piitaya deleted the fix_ha_form_multiple_data_set branch October 2, 2023 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authorize page inputs are buggy with dev build
2 participants