Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix choose description when a non-list form of conditions is used #18023

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Sep 25, 2023

Breaking change

Fix choose description generation when conditions is not a list. This can't happen through the UI editor, but it is a valid yaml syntax.

vuUlGhP

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

choose:
  - sequence: []
    conditions:
      condition: sun
      before: sunrise
enabled: true

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya merged commit c69fb77 into home-assistant:dev Sep 26, 2023
9 checks passed
@piitaya
Copy link
Member

piitaya commented Sep 26, 2023

Thank you!

@karwosts karwosts deleted the choose-alias-description-fix branch September 26, 2023 19:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants