Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop notifications for errors writing to system log #18022

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

steverep
Copy link
Member

Proposed change

We catch the errors, but not before hass.callService catches it an displays the toast. This just adds a parameter to turn off the notification.

Also removes some redundancies when calling console.error (since they are thrown too), and just shifts around a couple comments.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 1df1ce5 into dev Sep 26, 2023
9 checks passed
@bramkragten bramkragten deleted the stop-write-log-toast branch September 26, 2023 12:43
KTibow pushed a commit to KTibow/frontend-1 that referenced this pull request Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message: "Failed to call service system_log/write. unknown error" after update 2023.9.2
2 participants