Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brands URLs to use fallback search parameter #17986

Closed
wants to merge 1 commit into from

Conversation

steverep
Copy link
Member

@steverep steverep commented Sep 22, 2023

Proposed change

Needs home-assistant/brands#4708. Changes from /_/... to ...?fallback=true.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Design Related to Home Assistant design gallery label Sep 22, 2023
@frenck frenck marked this pull request as draft September 22, 2023 06:43
@frenck
Copy link
Member

frenck commented Sep 22, 2023

Converted to draft, as the solution this was built on, isn't viable for us to use.

@frenck
Copy link
Member

frenck commented Nov 29, 2023

@steverep Is this PR now ready for a follow-up? Or can we close it for now?

../Frenck

@steverep
Copy link
Member Author

@steverep Is this PR now ready for a follow-up? Or can we close it for now?

I need to re-throw up the changes to the brands repo first. Should be able to get to it soon.

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 28, 2024
@github-actions github-actions bot closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Design Related to Home Assistant design gallery stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants